Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus: no longer require mpirun for test passage #3584

Merged
merged 2 commits into from Nov 3, 2021

Conversation

jtkrogel
Copy link
Contributor

@jtkrogel jtkrogel commented Nov 3, 2021

Proposed changes

Addresses #3120. Nexus tests no longer strictly require mpirun. If mpirun is detected in the path, it is executed in the tests ("mpirun -np 1 echo run"). Otherwise a serial test is performed ("echo run").

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Laptop

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@qmc-robot
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jaron. I think this should be a more than good enough fix for the problems we have been seeing. It is simpler and more elegant than what I was envisaging (command line option) so I think we should go with your solution.

@ye-luo
Copy link
Contributor

ye-luo commented Nov 3, 2021

Test this please

@ye-luo ye-luo enabled auto-merge November 3, 2021 17:49
@ye-luo ye-luo merged commit 2a6f3a4 into QMCPACK:develop Nov 3, 2021
@williamfgc
Copy link
Contributor

Fixed unstable spock nightly test, nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants