Recompute DTAA at donePbyP on demand only. #3846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prckent
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
It would be very good to find a C++ architecture way to automatically handle these optional and/or state machine like options. This would surface the dependencies at the (say) the per class level. The same could be done for the numerically sensitive/need recompute wavefunction components.
|
Test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need #3838 and #3842
Proposed changes
Introduce DTModes::NEED_FULL_TABLE_ON_HOST_AFTER_DONEPBYP to handle DTAA recompute at donePbyP
on demand.
This is the last bits of putting CoulombPBCAA on the GPU.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Summit, Crusher
Checklist