Do not print initial memory availability for every MPI task #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ye-luo
reviewed
Aug 3, 2022
| { | ||
| if (OHMMS::Controller->rank() == proc) | ||
| { | ||
| fprintf(stderr, "Rank = %4d Free Memory = %5zu MB\n", proc, (freemem() >> 20)); |
There was a problem hiding this comment.
Please remove #include "Platforms/Host/sysutil.h" which is only need by freemem.
There was a problem hiding this comment.
I will take care of this as I'm preparing another similar change.
|
Printed max and min values would be good. I have caught issues in the past using the per MPI free memory report. |
|
Test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Increase output readability in MPI jobs by not printing free memory for every single MPI task. Rely on #4130 instead. If problems ever occur we could expand the #4130 report to include max and min values.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
nitrogen, nightly gcc 12 mpi configuration
Checklist