Add deterministic and statistical test for RMC density and spindensity check - #4327
Merged
Merged
Conversation
Contributor
|
It looks like this PR has coincided with a macos actions change, since the macos build now fails. Possibly with a real bug. I'll start the other tests in the interim in case updates to error bars are needed. |
Contributor
|
Test this please |
prckent
approved these changes
Nov 20, 2022
prckent
left a comment
prckent
left a comment
Contributor
There was a problem hiding this comment.
Thanks Hyeondeok. We can tackle the macos problem independently.
Contributor
|
Test this please |
prckent
enabled auto-merge
November 20, 2022 13:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR is to add missing RMC test for density and spin-density check. Deterministic and statistical tests are included for 1x1x1 diamond.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Intel Xeon, Theta, Summit
Checklist
Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.