Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deterministic and statistical test for RMC density and spindensity check #4327

Merged
merged 2 commits into from Nov 21, 2022

Conversation

Hyeondeok-Shin
Copy link
Contributor

Proposed changes

This PR is to add missing RMC test for density and spin-density check. Deterministic and statistical tests are included for 1x1x1 diamond.

What type(s) of changes does this code introduce?

  • Other (please describe): Add test

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Intel Xeon, Theta, Summit

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted
  • Yes. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@prckent
Copy link
Contributor

prckent commented Nov 18, 2022

It looks like this PR has coincided with a macos actions change, since the macos build now fails. Possibly with a real bug.

I'll start the other tests in the interim in case updates to error bars are needed.

@prckent
Copy link
Contributor

prckent commented Nov 18, 2022

Test this please

Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hyeondeok. We can tackle the macos problem independently.

@prckent
Copy link
Contributor

prckent commented Nov 20, 2022

Test this please

@prckent prckent merged commit db00ae7 into QMCPACK:develop Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants