Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus: Add Perlmutter to Nexus machines #4356

Merged
merged 5 commits into from
Dec 12, 2022
Merged

Conversation

aannabe
Copy link
Contributor

@aannabe aannabe commented Dec 7, 2022

Proposed changes

The Perlmutter class was added to Nexus machines. It should be able to handle both CPU and GPU jobs depending on the requested node type via the constraint keyword. The job style was adapted from:
https://docs.nersc.gov/systems/perlmutter/running-jobs/

Also, I removed the Edison class since it was retired more than 3 years ago:
https://www.nersc.gov/news-publications/nersc-news/nersc-center-news/2019/edison-supercomputer-to-retire-after-five-years-of-service/

What type(s) of changes does this code introduce?

  • New feature

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

  • Perlmutter

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@aannabe aannabe added the nexus label Dec 7, 2022
@jtkrogel
Copy link
Contributor

jtkrogel commented Dec 7, 2022

@aannabe thanks for adding this. Please update the tests in nexus/tests/unit/test_machines.py to include the output from nxs-test -R machines --job_ref_table that corresponds to Perlmutter (and also check that it looks sensible).

@aannabe
Copy link
Contributor Author

aannabe commented Dec 7, 2022

Edited the test_machines.py to account for Perlmutter and Edison changes. All the nxs-test tests are passing for me now.

@ye-luo ye-luo requested a review from jtkrogel December 8, 2022 03:22
@prckent prckent changed the title Add Perlmutter to Nexus machines Nexus: Add Perlmutter to Nexus machines Dec 8, 2022
@ye-luo
Copy link
Contributor

ye-luo commented Dec 12, 2022

Test this please

nexus/lib/machines.py Show resolved Hide resolved
nexus/lib/machines.py Show resolved Hide resolved
nexus/lib/machines.py Show resolved Hide resolved
@ye-luo ye-luo merged commit 800fec3 into QMCPACK:develop Dec 12, 2022
@aannabe aannabe deleted the nxs_perlmutter branch December 12, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants