Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for using parallel hdf5 in non-mpi build #4420

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

PhilipFackler
Copy link
Contributor

Proposed changes

Added check for when MPI is disabled but the parallel HDF5 library was found. This results in an error due to incompatibility, since the parallel HDF5 library cannot be used without MPI.
Closes #4370

What type(s) of changes does this code introduce?

  • Build related changes

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Ubuntu 22.04

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

Added check for when MPI is disabled but the parallel hdf5 library was
found. This results in an error due to incompatibility.
@williamfgc
Copy link
Contributor

Test this please

ye-luo
ye-luo previously approved these changes Jan 27, 2023
@ye-luo ye-luo enabled auto-merge January 27, 2023 18:09
@prckent
Copy link
Contributor

prckent commented Jan 27, 2023

Test this please

@ye-luo ye-luo merged commit fa62bd0 into QMCPACK:develop Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure when MPI is off with parallel HDF
4 participants