Remove all QMC_CUDA dependencies on testsets - #4442
Merged
Merged
Conversation
5 tasks
prckent
previously approved these changes
Feb 7, 2023
prckent
left a comment
prckent
left a comment
Contributor
There was a problem hiding this comment.
Confirmed that QMC_CUDA is gone from tests/*
Approving, of course subject to CI
Contributor
|
Test this please |
ye-luo
reviewed
Feb 7, 2023
ye-luo
left a comment
ye-luo
left a comment
Contributor
There was a problem hiding this comment.
Please remove SUCCESS_STATUS_CUDA and I will apply cmake-format before merging.
| else() | ||
| set(SUCCESS_STATUS_CUDA TRUE) | ||
| endif() | ||
| set(SUCCESS_STATUS_CUDA TRUE) |
Contributor
There was a problem hiding this comment.
This also needs to be removed.
Contributor
Author
There was a problem hiding this comment.
Thanks. SUCCESS_STATUS_CUDA is now completely removed.
Contributor
|
Test this please |
ye-luo
enabled auto-merge
February 7, 2023 22:18
ye-luo
reviewed
Feb 7, 2023
ye-luo
left a comment
ye-luo
left a comment
Contributor
There was a problem hiding this comment.
Will be last checked by CI.
ye-luo
approved these changes
Feb 7, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Since legacy CUDA is removed on #4431, QMC_CUDA dependencies on testsets are no longer needed.
What type(s) of changes does this code introduce?
Delete the items that do not apply
Does this introduce a breaking change?
What systems has this change been tested on?
Intel Xeon
Checklist
Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.