Skip to content

Nexus support for Kagayaki cluster at JAIST#4598

Merged
prckent merged 17 commits into
QMCPACK:developfrom
ichibha:develop
Jun 26, 2023
Merged

Nexus support for Kagayaki cluster at JAIST#4598
prckent merged 17 commits into
QMCPACK:developfrom
ichibha:develop

Conversation

@ichibha

@ichibha ichibha commented May 10, 2023

Copy link
Copy Markdown
Contributor

Proposed changes

This PR implements the Nexus settings for Kagayaki cluster at JAIST.

What type(s) of changes does this code introduce?

  • New feature

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Kagayaki cluster at JAIST.

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • N/A, only Python scripts are revised. Code added or changed in the PR has been clang-formatted.
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@jtkrogel

Copy link
Copy Markdown
Contributor

@ichibha all tests pass with nxs-test?

@prckent

prckent commented May 11, 2023

Copy link
Copy Markdown
Contributor

The Nexus tests are failing in CI. Maybe we need some more examples on how to add a machine and have the tests pass?

@ichibha

ichibha commented May 12, 2023

Copy link
Copy Markdown
Contributor Author

At least, I have to add Kagayaki in test_machines.py. I try to solve the errors myself first to pass this PR.

@jtkrogel

Copy link
Copy Markdown
Contributor

See also #4068 (comment)

@jtkrogel

Copy link
Copy Markdown
Contributor

@ichibha any luck?

@ichibha

ichibha commented Jun 25, 2023

Copy link
Copy Markdown
Contributor Author

@jtkrogel Currently, this specific test is the only one that fails. Is it related to the updates I made?

Before submitting the pull request, I have two tasks to complete:

  • Confirm that job_write_ref['kagayaki'] functions correctly in the current environment.
  • Enable the specification of number of OMP threads.
 61/69 qdens_radial............................   Failed  12.76 sec
Test name     : qdens_radial
Test sublabel : test_radial_density
Test exception: "AssertionError: "
Test backtrace:
  File "/Users/maezono/qmcpack/nexus//bin/nxs-test", line 478, in run
    self.operation()
  File "/Users/maezono/qmcpack/nexus//bin/nxs-test", line 1631, in qdens_radial
    nunit_all()
  File "/Users/maezono/qmcpack/nexus//bin/nxs-test", line 362, in nunit_all
    run_external_unit_test(test_name,unit_test)
  File "/Users/maezono/qmcpack/nexus//bin/nxs-test", line 388, in run_external_unit_test
    unit_test()
  File "/Users/maezono/qmcpack/nexus/tests/unit/test_qdens_radial.py", line 155, in test_radial_density
    assert(text_eq(out,out_ref))

@ichibha

ichibha commented Jun 26, 2023

Copy link
Copy Markdown
Contributor Author

@jtkrogel I wanted to inform you that the current version of our feature branch successfully passes all tests in the nxs-test suite with the exception of test 61/qdens_radial. I've been able to confirm that the generated PBS files are functioning as expected.

Given the above, I believe the branch is in a suitable state for merging. Please could you review and consider approving the merge request?

@ichibha

ichibha commented Jun 26, 2023

Copy link
Copy Markdown
Contributor Author

I performed nxs-test of the latest develop branch, and 61/qdens_radial failed.
Thus, the failure at 61/qdens_radial would not be because of my updates.

@mdewing

mdewing commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

Test this please

@mdewing

mdewing commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

@jtkrogel Is PR this okay with you? The nexus tests pass for me locally.

@jtkrogel

Copy link
Copy Markdown
Contributor

Yes it is. The qdens radial issue may be environment dependent and should be handled separately.

@prckent prckent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on discussion above

@prckent
prckent merged commit a61a10f into QMCPACK:develop Jun 26, 2023
@prckent prckent mentioned this pull request Aug 9, 2023
@prckent prckent mentioned this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants