Introduce ENABLE_PPCONVERT option and skip ppconvert compilation when cross compiling.#4601
Merged
Conversation
Contributor
Author
|
Test this please |
prckent
requested changes
May 12, 2023
Contributor
Author
|
A second thought on the name of the cmake option. QMC_USE_ISNAN is reserved for a global option. Here, there is special customization for ppconvert and thus introduce |
ye-luo
changed the title
Contributor
|
Test this please |
Contributor
|
Test this please |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
CrayLinuxEnvironment is considered cross-compiling. Thus try_run requires user input and stop.
Consider ppconvert is not critical, simply turn it off by default.
QMC_ISNAN option can be used to override the detection.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Frontier/Crusher
Checklist