Skip to content

Nexus: Adding crowds_serialize_walkers tag to dmc input list#4651

Merged
ye-luo merged 2 commits intoQMCPACK:developfrom
kayahans:crowd_serialize_walkers
Jun 29, 2023
Merged

Nexus: Adding crowds_serialize_walkers tag to dmc input list#4651
ye-luo merged 2 commits intoQMCPACK:developfrom
kayahans:crowd_serialize_walkers

Conversation

@kayahans
Copy link
Copy Markdown
Contributor

Proposed changes

Adds the crowds_serialize_walkers tag to the dmc input list in nexus.

What type(s) of changes does this code introduce?

  • New feature

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

macOS Monterey 12.6.3, Python 3.9.13

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@kayahans kayahans changed the title Update qmcpack_input.py Nexus: Adding crowds_serialize_walkers tag to dmc input list Jun 28, 2023
ye-luo
ye-luo previously approved these changes Jun 28, 2023
@ye-luo
Copy link
Copy Markdown
Contributor

ye-luo commented Jun 28, 2023

Test this please

@ye-luo ye-luo enabled auto-merge June 28, 2023 20:55
@kayahans
Copy link
Copy Markdown
Contributor Author

I have missed adding the write type in the first commit. It should now write yes/no rather than True/False.

@prckent
Copy link
Copy Markdown
Contributor

prckent commented Jun 28, 2023

Since this is motivated by #4648, I'll note that crowds_serialize_walkers will little influence CPU performance but will, in general, destroy GPU performance. So this debugging flag should be used with care until we have a fix for #4648.

@mdewing
Copy link
Copy Markdown
Contributor

mdewing commented Jun 29, 2023

Test this please

@ye-luo ye-luo merged commit 9a6e1d3 into QMCPACK:develop Jun 29, 2023
@prckent prckent mentioned this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants