Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply_rotation timer #4706

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Conversation

camelto2
Copy link
Contributor

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

adding a timer to the Phi->apply_rotation calls. Useful as we are testing some of the performance of orbital optimization

What type(s) of changes does this code introduce?

Delete the items that do not apply

  • New feature

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

macOS

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@camelto2
Copy link
Contributor Author

camelto2 commented Aug 21, 2023

@amandadumi and @jptowns, it looks like Josh merged some useful optimization timers in #4240. This is another timer which will explicitly time the underlying SPOSet implementation of applyRotation. Do you want any additional timers? Let me know and I'll add them here

@markdewing
Copy link
Contributor

Test this please

@camelto2 camelto2 removed the request for review from jptowns August 23, 2023 17:16
@markdewing markdewing merged commit e875bbd into QMCPACK:develop Aug 23, 2023
39 checks passed
@camelto2 camelto2 deleted the RotatedSPOs_timers branch August 23, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants