Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change findMSD return type to RefVector. #4826

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Change findMSD return type to RefVector. #4826

merged 2 commits into from
Nov 20, 2023

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Nov 9, 2023

Proposed changes

No more returns the first found one but all. More general.

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

epyc-server

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@ye-luo ye-luo requested a review from PDoakORNL November 9, 2023 22:59
PDoakORNL
PDoakORNL reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@PDoakORNL PDoakORNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionality is equivalent but this is less clear if the only possible states for the returned value are nothing or one element.

@ye-luo
Copy link
Contributor Author

ye-luo commented Nov 10, 2023

functionality is equivalent but this is less clear if the only possible states for the returned value are nothing or one element.

Prefer the user to handle size 0,1 and stop >=2.

PDoakORNL
PDoakORNL approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@PDoakORNL PDoakORNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@ye-luo
Copy link
Contributor Author

ye-luo commented Nov 20, 2023

Test this please

@ye-luo ye-luo merged commit e843a30 into QMCPACK:develop Nov 20, 2023
41 checks passed
@prckent prckent mentioned this pull request Nov 20, 2023
Merged
@ye-luo ye-luo deleted the query-MSD branch November 29, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PDoakORNL PDoakORNL PDoakORNL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ye-luo @PDoakORNL