Fix hybridrep complex #4939
Merged
Fix hybridrep complex #4939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test this please |
prckent
reviewed
Mar 8, 2024
ye-luo
commented
Mar 8, 2024
| @@ -128,7 +128,7 @@ class HybridRepReal : public SPLINEBASE, private HybridRepCenterOrbitals<typenam | |||
| const ValueVector& psiinv, | |||
| std::vector<ValueType>& ratios) override | |||
| { | |||
| if (VP.isOnSphere() && HYBRIDBASE::is_batched_safe(VP)) | |||
There was a problem hiding this comment.
The real case has the safety check already.
prckent
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Noticed a missing safety check in the complex code path of hybridrep.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Polaris
Checklist