Skip to content

Print more timing from various stages of optimization#4960

Merged
prckent merged 3 commits into
QMCPACK:developfrom
ye-luo:opt-output
Apr 19, 2024
Merged

Print more timing from various stages of optimization#4960
prckent merged 3 commits into
QMCPACK:developfrom
ye-luo:opt-output

Conversation

@ye-luo

@ye-luo ye-luo commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

Proposed changes

This is far from satisfactory. I would like to touch quite a few places but that will make review harder.
Treat this as the beginning.

What type(s) of changes does this code introduce?

  • New feature

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Polaris

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@ye-luo

ye-luo commented Apr 19, 2024

Copy link
Copy Markdown
Contributor Author

Test this please

@ye-luo

ye-luo commented Apr 19, 2024

Copy link
Copy Markdown
Contributor Author

Test this please

@prckent prckent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

A separate issue, but besides timers, much output cleanup for the optimizer is needed.

@prckent prckent merged commit 365f3ac into QMCPACK:develop Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants