Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 4975 via increased tolerance #5002

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

prckent
Copy link
Contributor

@prckent prckent commented May 21, 2024

Proposed changes

Closes #4975

For the reported supercell, the basis mapping was failing after 10K attempts due to numerical tolerance issues when Intel 2021.1 was used on the old CADES system . Tolerance was increased conservatively. Was unable to reproduce the problem with recent GCC, Clang etc. on other systems. Fix was verified with a generic (vs AVX512) build since I was using different nodes.

I will PR an updated build script when an updated cmake is installed by the admins.

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

ORNL CADES SHPC Condo. https://docs.cades.ornl.gov/#condos/overview/

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • NA. Documentation has been added (if appropriate)

@prckent
Copy link
Contributor Author

prckent commented May 21, 2024

Test this please

@ye-luo ye-luo enabled auto-merge May 21, 2024 15:56
@ye-luo ye-luo merged commit d0deeb9 into QMCPACK:develop May 21, 2024
40 checks passed
@prckent prckent deleted the fix_github_4975 branch May 21, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduced basis not found in allowed number of iterations
2 participants