Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Closes #4975
For the reported supercell, the basis mapping was failing after 10K attempts due to numerical tolerance issues when Intel 2021.1 was used on the old CADES system . Tolerance was increased conservatively. Was unable to reproduce the problem with recent GCC, Clang etc. on other systems. Fix was verified with a generic (vs AVX512) build since I was using different nodes.
I will PR an updated build script when an updated cmake is installed by the admins.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
ORNL CADES SHPC Condo. https://docs.cades.ornl.gov/#condos/overview/
Checklist
Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.