Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unlisted testbeds #787

Merged
merged 3 commits into from Apr 26, 2018
Merged

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Apr 25, 2018

Currently if a hostname is not recognized, the nightly tests script will abort.
Every time we add a machine, the script needs to be updated. This is not good.
This PR allows using a generic setting and pass extra parameters via environment variables or arguments.

The script for bora.alcf.anl.gov is an example.

@ghost ghost assigned ye-luo Apr 25, 2018
@ghost ghost added the in progress label Apr 25, 2018
@ghost ghost assigned markdewing Apr 26, 2018
Copy link
Contributor

@markdewing markdewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having all the information about different hosts centralized in one script is not a scalable design.

@markdewing markdewing merged commit 1493188 into QMCPACK:develop Apr 26, 2018
@ghost ghost removed the in progress label Apr 26, 2018
@ye-luo ye-luo deleted the allow-unlisted-testbeds branch April 26, 2018 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants