Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally hide join/leave and/or redacted events from the timeline #248

Closed
KitsuneRal opened this issue Dec 30, 2017 · 5 comments
Closed

Optionally hide join/leave and/or redacted events from the timeline #248

KitsuneRal opened this issue Dec 30, 2017 · 5 comments
Assignees
@KitsuneRal
Labels
enhancement A feature or change request for Quaternion

Comments

@KitsuneRal
Copy link
Member

This is a part of bigger #219 that is easy to implement and greatly improves experience with IRC netsplits. There should be a global setting, overridable per-room.
@KitsuneRal KitsuneRal added the enhancement A feature or change request for Quaternion label Dec 30, 2017
@KitsuneRal KitsuneRal added this to the 0.1 milestone Dec 30, 2017
@KitsuneRal KitsuneRal removed this from the 0.1 milestone Jan 9, 2018
@KitsuneRal KitsuneRal changed the title Optionally hide join/leave events from the timeline Optionally hide join/leave and/or redacted events from the timeline Aug 5, 2018
@KitsuneRal KitsuneRal self-assigned this Aug 5, 2018
@KitsuneRal
Copy link
Member Author

In the light of IRC spam this becomes quite needed.

@KitsuneRal
Copy link
Member Author

Closed by f3b13f6

KitsuneRal added a commit that referenced this issue Aug 12, 2018
@KitsuneRal
MEM::isUserActivityNotable: watch out for stateKey, not only sender
c0e387a 
If the base event is a state event, we consider stateKey instead of
sender; and we also check other state events' stateKey rather than
sender. This covers cases like kicking and (non-self-)banning. Closes
#248.
@peterhoeg
Copy link

So how does one hide the state changes @KitsuneRal? I haven't found a way to do that in Quaternion.

@KitsuneRal
Copy link
Member Author

It's in the menu: View ->Display in Timeline -> ... Of all state changes, only joins/leaves can be switched on/off for now.

@peterhoeg peterhoeg mentioned this issue Apr 25, 2019
Closed
5 tasks
@peterhoeg
Copy link

Should have found that, sorry. Thanks for the help.

nicolasfella pushed a commit to nicolasfella/Quaternion that referenced this issue Dec 27, 2020
@KitsuneRal
isEchoEvent: check the pending event for ids, not the synced one
be7d25e 
Synced events always have their event ids, so checking those for event id renders most of the function useless (and returns an incorrect result). Closes quotient-im#248.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KitsuneRal KitsuneRal

Labels
enhancement A feature or change request for Quaternion
Projects
Quaternion 1
Status: Versions 0.0.9.1-3 - Released
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterhoeg @KitsuneRal