Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling conversion options breaks encoding (Linux, 0.1.9, x64) #37

Closed
miniworm opened this issue Nov 26, 2015 · 5 comments
Closed

Enabling conversion options breaks encoding (Linux, 0.1.9, x64) #37

miniworm opened this issue Nov 26, 2015 · 5 comments
Assignees
Labels
Milestone

Comments

@miniworm
Copy link

Mostly i download subtitles in win1250. But sometimes files are in UTF-8 so i want to be sure that i've final subtitles in win1250. So i enable after enabling conversion options and selecting converting to win1250. But every subtitle after such conversion is gibberish. enca (Linux tool to check file charset) says final file is in UTF-8 but it isn't. It's some strange encoding.

@krzemin
Copy link
Member

krzemin commented Nov 26, 2015

Please check version 0.2.0. There were improvements applied in file encoding detection.

@miniworm
Copy link
Author

I've problem checking it - see #41

@miniworm
Copy link
Author

Still a lot of problems with conversion options on 0.2.0 and master from git. The only one which works all the time is "Nie dodawaj informacji o QNAPI". Charset conversion works only if i select manually input and output charset. Auto-detection doesn't work. The same with file type conversion.
When i say that it doesn't work i mean no final file on disk. Just like in #41 - i'm asked about choosing subtitle file but file disappears in conversion.

@miniworm miniworm changed the title Enabling convertion options breaks encoding (Linux, 0.1.9, x64) Enabling conversion options breaks encoding (Linux, 0.1.9, x64) Nov 26, 2015
@Nucleoprotein
Copy link

Reproduced encoding problem on Windows too.
Downloading SRT subtitle, original file is UTF-8 BOM, converted file is UTF-8 without BOM. Encoding of some characters is broken, also file have a garbage (bytes C4 8F C2 BB C5 BC) at start so it does not load in MPC-HC. Files here: http://www41.zippyshare.com/v/u68GiQjt/file.html

EDIT: I'm used charset auto-detection.

@krzemin krzemin added the bug label Dec 14, 2015
@krzemin krzemin added this to the 0.2.1 milestone Dec 14, 2015
@krzemin krzemin self-assigned this Dec 14, 2015
@krzemin
Copy link
Member

krzemin commented Dec 14, 2015

@Tapcio Thank you for the files. Auto-detection of file encoding was broken for non-polish subtitles. Bugfix will be available in 0.2.1 version.

@krzemin krzemin closed this as completed Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants