-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidating similar units across systems #56
Comments
Other changes:
|
Copying the notes on the differences between the various IX units from #65:
|
As the many of the units (especially data) are specific to each system despite the similarity in their names, I think it'd better to consolidate the units for one system into one module, will do this when merging the |
There are several similar units in different systems (e.g.,
IndustrialControlPanel
,SystemControls
), I'd like to consolidate them into fewer modules with some renaming for consistency and better organization, specificallyThe following units will go into qsdsan/sanunits/_ion_exchange.py (see #55):
IonExchangeNH3
IonExchangeReclaimer
IonExchangeNEWgenerator
The following units will go into qsdsan/sanunits/_controlling.py:
IndustrialControlPanel
(renamed toControlBoxOP
)SystemControls
(this one is diff from others, maybe leave this out)SCGZyclonicControlBox
RecyclingControls
ControlSystem
The following units will go into qsdsan/sanunits/_hxs.py:
OilHeatExchanger
HydronicHeatExchanger
DryerFromHHX
(renamed toHHXdryer
)The text was updated successfully, but these errors were encountered: