Deprecate Pool threads #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of writing this PR, I'm deprecating the Pool threads in favour of implementing your own threads. This is because the Pool thread template is useless as only database thread. Implementing your own can include additional logic which will be more helpful anyway.
Lastly, as threads' MessagePorts can't transfer functions, it doesn't allow to process iterating queries (as those methods use functions to determine filtering or the transfer of iterations). As those iterative queries are mostly always the slowest, that defeats the purpose of the thread.
Parallelising requests in a web server with your own instance of the database for each thread would be faster, too