fix recurrence for months, years, and multi-digit increments #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: Recurrence periods in months
m
were re-calculated as weeks, which created an unexpected offset, e.g., 28 days instead of 1 month (which could have 30 or 31 days). As the number of months grows, the offset grows to a week or more. Recurrence periods in yearsy
were recalculated as x years times 52 weeks, which created offsets as well.Now: This is fixed, a month is a month and a year is a year, without using approximations in weeks.