Skip to content

Commit

Permalink
add comment on R3IcoConv as in #52
Browse files Browse the repository at this point in the history
  • Loading branch information
Gabri95 committed Jun 21, 2023
1 parent 146d4e7 commit 0e8d301
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions escnn/nn/modules/conv/r3_ico_convolution.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,14 @@ def __init__(
This class is mostly similar to :class:`~escnn.nn.R3Conv`, with the only difference that it only supports the
group :class:`~escnn.group.Icosahedral` since it uses a kernel basis which is specific for this group.
.. warning ::
With respect to :class:`~escnn.nn.R3Conv`, this convolution layer uses a different steerable basis
to parameterize its filters. This basis does not rely on band-limited spherical harmonics but on
a finite number of orbits of the Icosahedral group in :math:`\R^3`.
This basis is less robust to discretization (see Figure 5 in `our paper
<https://openreview.net/pdf?id=WE4qe9xlnQw>`_ ).
For this reason, using the :class:`~escnn.nn.R3Conv` class is often preferable.
The argument ``frequencies_cutoff`` of :class:`~escnn.nn.R3Conv` is not supported here since the steerable
kernels are not generated from a band-limited set of harmonic functions.
Expand Down

0 comments on commit 0e8d301

Please sign in to comment.