Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added /con_tilde_mode "2" - fixed annoying behavior of /con_tilde_mode "1" - console is not closing on second tilde press #4

Merged
merged 2 commits into from
Jun 2, 2011

Conversation

uzhosnah
Copy link
Contributor

added new value for variable con_tilde_mode (con_tilde_mode=2).
in this mode, tilde is closing console when console line is empty.
when line is not empty, tilde is added to line

added new value for variable con_tilde_mode (con_tilde_mode=2).
in this mode, tilde is closing console when console line is empty.
when line is not empty, tilde is added to line
johnnycz added a commit that referenced this pull request Jun 2, 2011
con_tilde_mode 2: tilde closes console when edit line is empty
IRC: utf-8 support
@johnnycz johnnycz merged commit 6e78a4f into QW-Group:master Jun 2, 2011
@johnnycz
Copy link
Contributor

johnnycz commented Jun 2, 2011

Thank you for the contribution and sorry for the delay.

Some comments for the future:

  • Please take care when writing the commit message. First line should be max 60 chars long and should describe briefly what change was done. Then comes an empty line and then full description of the change. - Important
  • Lengthy sequences of encapsulated if-then statements should be avoided (use sub-procedure).
  • Macros that do not have constant value should be defined with parentheses. So CONSOLELINEEMPTY() instead of just CONSOLELINEEMPTY
  • Macros that are used only in single module do not need to be defined in header (CONSOLELINEEMPTY could have been put in keys.c) minor

@uzhosnah
Copy link
Contributor Author

uzhosnah commented Jun 7, 2011

ok. thanks for notes

have a question: is there an actual public repo for documentation? what is synced with ezquake.sourceforge.net/docs site?
i want to describe /con_tilde_mode "2"

---- On Thu, 02 Jun 2011 13:40:46 -0700 johnnycz <reply@reply.github.com> wrote ----

Thank you for the contribution and sorry for the delay.

Some comments for the future:

  • Please take care when writing the commit message. First line should be max 60 chars long and should describe briefly what change was done. Then comes an empty line and then full description of the change. - Important
    • Lengthy sequences of encapsulated if-then statements should be avoided (use sub-procedure).
    • Macros that do not have constant value should be defined with parentheses. So CONSOLE_LINE_EMPTY() instead of just CONSOLE_LINE_EMPTY
    • Macros that are used only in single module do not need to be defined in header (CONSOLE_LINE_EMPTY could have been put in keys.c) minor

Reply to this email directly or view it on GitHub:
#4 (comment)

@johnnycz
Copy link
Contributor

johnnycz commented Jun 8, 2011

No, access to documentation is restricted.

I have now updated the documentation of con_tilde_mode. Check it out and let me know in case you'd change anything.
http://ezquake.sourceforge.net/docs/?vars-hud#con_tilde_mode

@uzhosnah
Copy link
Contributor Author

uzhosnah commented Jun 8, 2011

tilde docs are good now.

question about IRC.
i've got a suggestion to make "ignore_irc" option. it should display messages from IRC in console, but don't show them on game screen, because it can distract in important match.
there is no correct way to do this without big hacks in code, isn't it?

@johnnycz
Copy link
Contributor

johnnycz commented Jun 8, 2011

Yeah, I don't think that is easily possible.

For example FTEQW has a concept of multiple consoles where IRC is send to separated console, and other stuff to different console(s). Then it's somehow determined what gets displayed where. But it's of course lots of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants