-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove code that forces lowercase text in console #6
Conversation
Apparently someone discovered that their binds break if capslock gets A better way to fix this should be to use Key_EventEx instead of Tonik. On 12/14/2011 11:36 PM, Andrew Donaldson wrote:
|
Apparently there seems to be a difference in behavior whether the symbol WITH_KEYMAP is defined or not. At least in Key_Event() there is difference how Key_EventEx() is called from there. I have no idea what would be the correct thing to do here on osx. Do we support keymap? It is defined by default on osx. Maybe things magically will work when you undefine it. Probably the WITH_KEYMAP feature should be fixed? :-) |
On Windows at least, WITH_KEYMAP is a legacy of the times when we didn't The one correct solution, and I hope it's currently the default one in To my knowledge, this philosophy only really works in Windows right Tonik. On 12/15/2011 01:13 AM, Florian Zwoch wrote:
|
This change allows the user to type LOUDLY and still trigger binds. I'm not sure of the performance impact of having a conditional here, or using tolower(). |
Does it make more sense to just: #ifndef WITH_KEYMAP And remove WITH_KEYMAP from the preprocessor defines? Maybe #ifdef instead of #ifndef - I lost track of it which is recommended. But hopefully you get the idea.. |
I'll have another look at this. (Note to self: https://github.com/ezQuake/ezquake-source/blob/master/keys.c#L2358-2368 ) |
I have simply removed the WITH_KEYMAP preprocessor define and it seems to restore the availability to write upper case letters.. please try and report. |
Cool. I'll give this a bash later. I would have done this myself but I wasn't sure of the function of WITH_KEYMAP on OSX (despite the thorough explanation above). |
Works for me. When will the next OSX release be? |
I was experiencing a strange issue in OSX ezQuake, where I wasn't able to SHOUT AT PEOPLE INGAME. IT WAS REALLY STRANGE.
I had a wee dig about in the code and found this line. From the looks of it it's deliberately converting the text to lowercase, but I can't see why.
Anyway, this works for me and I can't figure out any fallout, so I thought I'd share.
(Background: http://www.quakeworld.nu/forum/viewtopic.php?id=5569)