metaVolumes for #496 #631
Merged
metaVolumes for #496 #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianseeger
changed the title
audax
reviewed
Oct 18, 2016
| return PrefixChooser( | ||
| identityRepository, | ||
| { createNewPrefix(identity, boxClient, identityRepository) }, | ||
| { prefix -> hasIndex(identity, prefix, type) }, |
There was a problem hiding this comment.
Using named parameters for this would make it more readable. This way I have to know which callback should do what
|
Make this a default parameter, on android we have to inject the temp directories |
julianseeger
commented
Oct 19, 2016
| = { prefix -> BlockReadBackend("$blockUri/api/v0/files/$prefix/", boxClient) }, | ||
| val writeBackendFactory: (String) -> StorageWriteBackend | ||
| = { prefix -> BlockWriteBackend("$blockUri/api/v0/files/$prefix/", boxClient) } | ||
| ) : AbstractBoxVolumeFactory(boxClient, identityRepository, directoryFactory) { |
julianseeger
commented
Oct 19, 2016
| return PrefixChooser( | ||
| identityRepository, | ||
| { createNewPrefix(identity, boxClient, identityRepository) }, | ||
| { prefix -> hasIndex(identity, prefix, type) }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes the new box prefix choosing algorithm:
Prefixes are chosen separately for the types USER and CLIENT