Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The same code inside and many others #129

Closed
tigertv opened this Issue Mar 14, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@tigertv
Copy link

tigertv commented Mar 14, 2019

if(mpfr_cmpabs(i_value->internalLowerFloat(), i_value->internalUpperFloat()) > 0) {
mpfr_sqr(f_tmp, i_value->internalLowerFloat(), MPFR_RNDU);
mpfr_sub(f_rl, f_rl, f_tmp, MPFR_RNDD);
} else {
mpfr_sqr(f_tmp, i_value->internalLowerFloat(), MPFR_RNDU);
mpfr_sub(f_rl, f_rl, f_tmp, MPFR_RNDD);
}

Also, see https://www.viva64.com/en/b/0616/

@tigertv tigertv changed the title The same code inside, and many others The same code inside and many others Mar 14, 2019

hanna-kn added a commit that referenced this issue Mar 14, 2019

Fix code errors listed at https://www.viva64.com/en/b/0616/ (issue #129
…); Fix show repeating decimals in combination with show ending zeroes for rational numbers; Deprecate getBestUnit and convertToBestUnit, replaced with ...OptimalUnit, and replace getBest...Prefix with getOptimal...Prefix, in Calculator class
@hanna-kn

This comment has been minimized.

Copy link
Contributor

hanna-kn commented Mar 14, 2019

Fixed.

Most listed errors were harmless or affected very unusual use cases. The most critical error was only present in unreleased code and had already been fixed. The example above in Number.cc resulted in a potentially too narrow interval when calculating the square of a complex interval with different sign for upper and lower endpoint.

@hanna-kn hanna-kn closed this Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.