Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[From Debian BTS] Currency symbol for U.S. dollar is '$', but should be 'USD'. #222

Open
RogueScholar opened this issue Sep 11, 2020 · 3 comments

Comments

@RogueScholar
Copy link

Hi @hanna-kn,

I'm in the process of imploding the current Debian packaging configuration for both halves of the Qalculate! project in order to get them into a condition that will hopefully see them keep much more closely attuned to your releases here. While doing so I've kept an eye on all the malingering bug reports on the vendor side that accumulated during the project's semi-dormant period roughly a decade ago in the hopes of wiping the slate clean again. I've actually gotten all of the Debian and Ubuntu bugs ready to join the history books now (:tada:), save this one on the Debian BTS which raises a user/maintainer concern that is still valid.

While I'm inclined to agree with the requested change, I also suspect that it's partly addressed by the default currency setting, no? I'm too deep in the packaging swamp to give it adequate consideration, to say nothing of the fact that, as an American, I find it appropriate to let us have the dollar sign since we were responsible for its genesis, with any collateral confusion being nothing more than a copycats' wages. 😀 All joking aside though, if you determine that this falls into the "WON'T FIX" pile I'll advocate for the same tag on DBTS without objection; I don't want my cleanup project to devolve into a burden on you too.

I hope to have the patches that were necessary to apply to your upstream codebase to bring everything into compliance with the latest Debian Standards turned into PRs for your review sometime next week. If you're curious to see what the end result is shaping up to look like for the Debian packages, here are some links to the CI/CD workflow I have running on Launchpad to help me catch any straggling vermin before I find a sponsor for their upload to the Debian archives. I'd welcome any thoughts or feedback you had on any of it, including what might still need polishing or if any of the changes strike you as ill-considered.

That's all I've got for you now. I hope this message finds you healthy and safe. No hurry on attending to anything herein either; I've got plenty still to occupy myself with.

Warmly,
Peter

hanna-kn added a commit that referenced this issue Sep 11, 2020
…e) using ISO 4217 code (e.g. USD instead dollar); Do not use "$", "dollar", and "dollars" for USD if symbol for local currency is "$" (issue #222)
hanna-kn added a commit that referenced this issue Sep 11, 2020
…; Do not use "£" for GBP if symbol for local currency is "£"
@hanna-kn
Copy link
Contributor

hanna-kn commented Sep 11, 2020

I think the advantages outweigh the disadvantages with using $ for USD by default.

I've now made the following changes:

  • Show parsed expression using "USD" instead of "dollar"
  • Do not use "$", "dollar", and "dollars" for USD and remove cent, if symbol for local currency is "$"

It would be possible automatically add "$" symbol to the local currency when appropriate, but I'm unsure if this is a good idea.

It is possible for translations to change the symbols for USD and other currencies (e.g. "kr" is added as symbol for SEK in the Swedish translation).

All this also applies to "£" (by default used as symbol for GBP).

@emorrp1
Copy link
Contributor

emorrp1 commented Feb 14, 2021

@hanna-kn I think that's a reasonable solution

@RogueScholar would you be willing to maintain this package upstream in Debian (and did you start your work from the git version in salsa)? I only recently noticed it won't be included in bullseye, but I've just triaged all the bugs in the bts to test with latest versions.

@emorrp1
Copy link
Contributor

emorrp1 commented Apr 19, 2021

Hello Peter / @RogueScholar,

Thank you for your packaging work in Ubuntu, I was wondering if you'd like to contribute via Debian too? I've only got bounces by email, so trying one more time to see if this gets through to you.

I see you've already registered on salsa, so I've gone ahead and granted you full access to the repos. I've also merged your existing work that was licensed under Apache-2.0 or GPL-2.0-or-later, are you happy to relicense your subsequent work from v3+ to v2+ to match the author? All libqalculate bugs in Launchpad are unreproducible in 2.8.2, so I suggest you mark them as resolved already.

https://salsa.debian.org/debian/libqalculate

https://salsa.debian.org/debian/qalculate-gtk

team+qalculate@tracker.debian.org

-- Phil Morrell (emorrp1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants