Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gfg.js #310

Merged
merged 5 commits into from
Oct 9, 2022
Merged

Update gfg.js #310

merged 5 commits into from
Oct 9, 2022

Conversation

ASahu16
Copy link
Contributor

@ASahu16 ASahu16 commented Jul 17, 2022

Fix #307

@QasimWani
Copy link
Owner

thanks for taking charge of this. looking into it

scripts/gfg.js Outdated Show resolved Hide resolved
scripts/gfg.js Show resolved Hide resolved
scripts/gfg.js Outdated Show resolved Hide resolved
scripts/gfg.js Show resolved Hide resolved
scripts/gfg.js Show resolved Hide resolved
@ASahu16 ASahu16 requested a review from QasimWani July 19, 2022 05:54
@kshitijmishra27
Copy link

sir please do changes so that it can work now....you are the only hope @ASahu16

@ASahu16
Copy link
Contributor Author

ASahu16 commented Jul 23, 2022

sir please do changes so that it can work now....you are the only hope @ASahu16

@kshitijmishra27 you mean this fix is not working?
If yes, please add more info so I can replicate the issue.

The old selector element gets removed from the DOM when the output window close is closed.
@ASahu16
Copy link
Contributor Author

ASahu16 commented Jul 25, 2022

@QasimWani PTAL.

@heysujal
Copy link

i think submit button ID has also been changed . Infact it is completely removed and given a class name of problems_submit_button__6QoNQ

@ASahu16
Copy link
Contributor Author

ASahu16 commented Aug 28, 2022

i think submit button ID has also been changed . Infact it is completely removed and given a class name of problems_submit_button__6QoNQ

The whole site has been migrated on Next.js.
In this PR submit button is captured using the document.evaluate() based upon the text content("submit"), previously it was captured using document.getElementById('run') method call.
You can check the diff.
Hope it helps! ✌️

@ankitkashyap12
Copy link

Hi Qasim, can this change be merged please if it's all good? I need it to have GFG codes on the repo. This is an awesome extension. Hopefully, this issue gets resolved soon.

Copy link
Owner

@QasimWani QasimWani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this works functionally, there's no message showing that it works. On leetcode.com, we have a spinner showing the state of merge. Works for now, but additional changes needed for better UX.

@QasimWani QasimWani merged commit 8db4314 into QasimWani:main Oct 9, 2022
@ASahu16
Copy link
Contributor Author

ASahu16 commented Oct 9, 2022

while this works functionally, there's no message showing that it works. On leetcode.com, we have a spinner showing the state of merge. Works for now, but additional changes needed for better UX.

Sure we'll try to add that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LeetHub doesn't work at GFG now
5 participants