Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Stats in Commit Msg and Bug Fixes #38

Merged
merged 5 commits into from
Dec 5, 2020

Conversation

JeremyTsaii
Copy link
Contributor

Implemented problem solve stats to show up in the commit messages (ex. "Time: 16 ms (92.94%), Space: 13.6 MB (75.07%) - LeetHub"). I believe this will be helpful for users to easily see how their code stacked up against other submissions, when reviewing on GitHub. While implementing this, I also fixed the "unknown-problem" error and made it so that the README is only written when the first problem is solved, instead of repetitively on every submission. Let me know what you think.

Copy link
Owner

@QasimWani QasimWani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@QasimWani QasimWani merged commit ec01374 into QasimWani:dev Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants