Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mozilla addon link to the readme #392

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

ArjixWasTaken
Copy link
Contributor

and improved the readme a bit, just a tiny bit

@ArjixWasTaken
Copy link
Contributor Author

image

@ArjixWasTaken
Copy link
Contributor Author

ArjixWasTaken commented Oct 20, 2022

unless the mozilla addon is unofficial...i dont really know

PS: If it is unofficial, you can easily upload the extension to firefox, it works as is, you just need a free developer account

@ArjixWasTaken
Copy link
Contributor Author

ArjixWasTaken commented Oct 20, 2022

PS: the firefox image I used is an edit I made of chrome's badge, and I allow you to use it

@QasimWani
Copy link
Owner

QasimWani commented Oct 20, 2022

This is cool. There has been a firefox fork developed by @njelich. The current version is developed by Max. There's no such thing as official and official. Pretty decentralized when it comes to the that 😉

@@ -1,40 +1,44 @@
<h1 align="center">
<a href="https://standardjs.com"><img src="assets/octocode.png" alt="LeetHub - Automatically sync your code to GitHub." width="400"></a>
<br>
<a href="https://chrome.google.com/webstore/detail/leethub/aciombdipochlnkbpcbgdpjffcfdbggi">LeetHub</a> - Automatically sync your code to GitHub.
<a href="https://github.com/QasimWani/LeetHub">LeetHub</a> - Automatically sync your code to GitHub.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aashu
Copy link

aashu commented Oct 30, 2022

@QasimWani I tried loading leethub directly from this repo and it was working without any issues. So I don't think there is any requirement to maintain a seperate fork for firefox. Also, the fork you are talking about doesn't seems to be updated since April. It would be great if we can use this repo only and list extension to firefox addons store.

@njelich
Copy link
Contributor

njelich commented Oct 30, 2022

@aashu Yep, my changes added compatibility and it was merged to the main repo.

@QasimWani QasimWani merged commit e7d6dd5 into QasimWani:main Oct 31, 2022
@ArjixWasTaken ArjixWasTaken deleted the patch-1 branch October 31, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants