Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Display Specifiers objects analysis #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fanaw
Copy link
Contributor

@Fanaw Fanaw commented Oct 2, 2023

This PR adds analysis of Display Specifier objects in the Configuration naming context.

Modified Display Specifiers can add new menu contexts in the ADUC admin tool, which may make execute arbitrary code unwittingly to administrators.

Here is an example when the user-Display Display Specifier is modified:
image
image
image
(Remote files can also be executed this way).

This PR compares current values of adminContextMenu of every Display Specifier to extracted default values.
When there is a mismatch, it is reported as output like other commands (example in JSON format):
image

@Fanaw
Copy link
Contributor Author

Fanaw commented Oct 4, 2023

After running this function in a real AD environement, I realized Display Modifier values are MUCH more heterogeneous than a default AD. I am going to review my code to check if dangerous files could be run through DM instead of comparing to default values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant