Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/bridge: GetPlayerByPhone() #270

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix/bridge: GetPlayerByPhone() #270

merged 1 commit into from
Dec 4, 2023

Conversation

jnccloud
Copy link
Contributor

@jnccloud jnccloud commented Dec 4, 2023

Description

Caused an error when using GKS Phone. Looks like a typo.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

mafewtm
mafewtm approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@mafewtm mafewtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this appears to be correct as this is the export here

@Manason Manason merged commit 8313bd5 into Qbox-project:main Dec 4, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manason Manason Manason approved these changes

@mafewtm mafewtm mafewtm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jnccloud @Manason @mafewtm