Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server/events): fix license sometimes being used instead of license2 #278

Merged
merged 1 commit into from
Dec 9, 2023
Merged

fix(server/events): fix license sometimes being used instead of license2 #278

merged 1 commit into from
Dec 9, 2023

Conversation

D4isDAVID
Copy link
Member

@D4isDAVID D4isDAVID commented Dec 9, 2023 •
edited
Loading

Description

In the playerConnecting event, use GetPlayerIdentifierByType instead of looping over GetPlayerIdentifiers to guarantee using license2 over license when available.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

@ChatDisabled ChatDisabled merged commit 41f8380 into main Dec 9, 2023
3 of 4 checks passed
@D4isDAVID D4isDAVID deleted the fix/connecting-license2 branch December 9, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manason Manason Manason approved these changes

@mafewtm mafewtm mafewtm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@D4isDAVID @Manason @mafewtm @ChatDisabled