feat: switch from utils to lib #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manason
requested changes
Jan 17, 2024
Manason
approved these changes
Jan 17, 2024
D4isDAVID
requested changes
Jan 17, 2024
There was a problem hiding this comment.
There are some comments here about cases that QBCore handles but we don't. I'm not exactly strict about this, but I believe it would be nice to handle those cases ourselves too to improve compatibility.
There are also some ped-related functions that support an ignoreList in QBCore but not in lib anymore, it's possible to copy some stuff from the utils module to do that.
Co-authored-by: David Malchin <malchin459@gmail.com>
Co-authored-by: David Malchin <malchin459@gmail.com>
Co-authored-by: David Malchin <malchin459@gmail.com>
Co-authored-by: David Malchin <malchin459@gmail.com>
Co-authored-by: David Malchin <malchin459@gmail.com>
Co-authored-by: David Malchin <malchin459@gmail.com>
BerkieBb
reviewed
Jan 17, 2024
|
All comments resolved now |
D4isDAVID
requested changes
Jan 20, 2024
D4isDAVID
approved these changes
Jan 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch from the deprecated utils module to the new lib module
Checklist