Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge/qb/client/functions): restore backwards compatibility #337

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

Manason
Copy link
Member

@Manason Manason commented Jan 28, 2024

v1.5.0 broke backwards compatibility by changing some function headers and behaviors. This restores the behavior to what it was prior to v1.5.0

@D4isDAVID
Copy link
Member

The original QBCore functions GetVehicles, GetObjects, GetPlayers, GetClosestVehicle and GetClosestObject don't actually take in an ignoreList. The original GetClosestPlayer doesn't take a maxDistance either.

Although it was like this before v1.5.0, is this not invalid? Or is this already used by some users?

bridge/qb/client/functions.lua Show resolved Hide resolved
bridge/qb/client/functions.lua Show resolved Hide resolved
bridge/qb/client/functions.lua Show resolved Hide resolved
@Manason Manason merged commit 8f253e0 into main Jan 29, 2024
4 checks passed
@Manason Manason deleted the fix-bridge-client-backwards-compat branch January 29, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants