Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove leftover data tables #478

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

t0r3tto
Copy link
Contributor

@t0r3tto t0r3tto commented Jun 5, 2024

Description

remove deprecated character data tables that are no longer used
image
(^ clean recipe deployment warnings)

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@solareon
Copy link
Member

solareon commented Jun 5, 2024

Sadly these have to stay. If users are converting from qb-core then they may have characters in those tables that need to be cleaned up when a character is deleted. A possible solution for this would be to copy a different config file in the txadmin recipe for clean installs over this file to prevent the warnings.

@solareon solareon closed this Jun 5, 2024
@solareon solareon reopened this Jun 5, 2024
Copy link
Member

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion, I think the right choice is indeed to cater to recipe installs. That means that those converting from qb-core will have to pay special attention to the config to ensure they add any missing tables that they have. They should already be going through the config as part of the conversion process however, so this seems like the right call.

@Manason Manason merged commit 3767824 into Qbox-project:main Jun 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants