replaced lib.waitFor with while, in qbx.spawnVehicle

[abdel1touimi]

Description

Checklist

• I have personally loaded this code into an updated Qbox project and checked all of its functionality.
• My pull request fits the contribution guidelines & code conventions.

[solareon]

This could also be improved by an extension to the lib.waitFor that provides the ability to return to a different callback, in this case to delete the entity rather than erroring.

[solareon]

We can replace this with something like this (untested)

local timeout = 5000
local targetOwner = ped and NetworkGetEntityOwner(ped) or false
while timeout >= 0 do
    local owner = NetworkGetEntityOwner(veh)
    if (targetOwner and owner == targetOwner) or (not targetOwner and owner ~= -1) then
        break
    end
    timeout -= 10
    if timeout <= 0 then
        DeleteEntity(veh)
        error('Deleting vehicle which timed out finding an owner')
    end
    Wait(10)
end

[solareon]

Similar fix for this section also untested

if props and type(props) == 'table' and props.plate then
    state:set('setVehicleProperties', props, true)
    timeout = 5000
    while timeout > 0 do
        if qbx.string.trim(GetVehicleNumberPlateText(veh)) == qbx.string.trim(props.plate) then
            break
        end
        timeout -= 10
        if timeout <= 0 then
            DeleteEntity(veh)
            error('Deleting vehicle which timed out setting vehicle properties')
        end
        Wait(10)
    end
end

[abdel1touimi]

This could also be improved by an extension to the lib.waitFor that provides the ability to return to a different callback, in this case to delete the entity rather than erroring.

Yes I agree. until then we have no choice here

[Manason]

Alternative solution: #507