Database refactor #63
Conversation
| CREATE TABLE IF NOT EXISTS `bans` ( | ||
| `id` int(11) NOT NULL AUTO_INCREMENT, | ||
| `name` varchar(50) DEFAULT NULL, | ||
| `license` varchar(50) DEFAULT NULL, | ||
| `discord` varchar(50) DEFAULT NULL, | ||
| `ip` varchar(50) DEFAULT NULL, | ||
| `reason` text DEFAULT NULL, | ||
| `expire` int(11) DEFAULT NULL, | ||
| `bannedby` varchar(255) NOT NULL DEFAULT 'LeBanhammer', | ||
| PRIMARY KEY (`id`), | ||
| KEY `license` (`license`), | ||
| KEY `discord` (`discord`), | ||
| KEY `ip` (`ip`) | ||
| ) ENGINE=InnoDB AUTO_INCREMENT=1; |
There was a problem hiding this comment.
i guess we really shouldn't manage that ourselves and use txadmin's bans instead cauz txadmin actually maintains that system
There was a problem hiding this comment.
Yeah bans should not be handled in the core cuz FUCK me that was a shit system, hopefully TXAdmin intergrates a ban so we can run it through txadmin completely
There was a problem hiding this comment.
Yeah bans should not be handled in the core cuz FUCK me that was a shit system, hopefully TXAdmin intergrates a ban so we can run it through txadmin completely
shouldn't be hard to pr exports for their moderation tools 🤔
There was a problem hiding this comment.
shouldn't be hard to pr exports for their moderation tools 🤔
The hard part is always getting the PR approved
There was a problem hiding this comment.
i have experienced that part
| @@ -12,32 +9,16 @@ CREATE TABLE IF NOT EXISTS `players` ( | |||
| `inventory` longtext DEFAULT NULL, | |||
| `last_updated` timestamp NOT NULL DEFAULT current_timestamp() ON UPDATE current_timestamp(), | |||
| PRIMARY KEY (`citizenid`), | |||
| KEY `id` (`id`), | |||
| FOREIGN KEY (`userid`) REFERENCES `users` (`userid`) ON DELETE CASCADE ON UPDATE CASCADE, | |||
There was a problem hiding this comment.
Interesting discussion was had last night regarding updating cached values when deletes/updates are cascaded. While the FK constraint is great, we need to have a discussion on whether we want to cascade deletes/updates on the DB and figure out an alternate cache solution, or otherwise keep the cascades within lua code so that the cache can be easily updated.
|
After trying out the changes in an environment this is not going to work. Removing citizenid and not generating it ad the start will cause a heap of problems, since so many scripts relies on it, not sure what the appropriate solution here would be, since the current PR’ed solution seems like it’s not going to fly. |
|
yeah there's no way this pr works lol |
Description
Gotta start somewhere, please contribute to this lol
Checklist