Update options CSS #117
Update options CSS #117
Conversation
Upstream source for the file has been moved. Let's rename accordingly, before we update the file.
We introduced a copy of upstream CSS nearly three years ago; it changed quite a lot since then, and some elements do no longer render properly in accordance with the rest of Thunderbird's style (see PR #116). Let's update the file by copying the current version [0], trimming down unused items, and replacing ":root" with "body". [0] changeset 636997:517d690052a2)
|
Linking https://bugzilla.mozilla.org/show_bug.cgi?id=1678150 here so I don't lose it again. |
|
This is great for now :). I just don't think this approach of copying this CSS file from Thunderbird is good. Having to do that update every time is a bit cumbersome. I never developed add-ons for Thunderbird, maybe there is a better way of doing that. If you have any ideas I'm willing to do them ;). Thank you for your time maintaining this project! |
Totally agree. I'd love to avoid that, too, but this is the best solution I've found so far to get a consistent visual on the option page.
I've hacked a few things for Thunderbird, but it could well be that there's a better solution and I don't know about it. I'm not well versed into all the possibilities for add-ons. The thing is that it's nearly possible to include the file from Thunderbird directly, without having to copy/embed it in the add-on. Last time I tried, it's just that the CSS selectors At least, doing an update of the file once every three years is not that much work. But yeah, I hope that eventually this issue is solved and we can just include Thunderbird's CSS for the option page.
I need it to work, too :) |
We introduced a copy of upstream CSS nearly three years ago; it changed quite a lot since then, and some elements do no longer render properly in accordance with the rest of Thunderbird's style (see PR #116). Let's update the file by copying the current version [0], trimming down unused items, and replacing
:rootwithbody, as we did already for the previous version.[0] changeset 636997:517d690052a2)