Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The delay closing feature of an incoming TCPConn will make memory leak #18

Closed
zieckey opened this issue Mar 24, 2017 · 1 comment
Closed
Labels

Comments

@zieckey
Copy link
Collaborator

zieckey commented Mar 24, 2017

If TCPServer has a TCPConn to be delay closing, we set a timer to it :
loop_->RunAfter(close_delay_, std::bind(&TCPConn::HandleClose, shared_from_this()));

And now we stop the whole TCPServer immediately, this timer will never be invoken.

zieckey added a commit that referenced this issue Mar 24, 2017
zieckey added a commit that referenced this issue Mar 24, 2017
@zieckey zieckey added the bug label Mar 24, 2017
@zieckey
Copy link
Collaborator Author

zieckey commented Mar 24, 2017

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant