Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.2: failed test #87

Closed
remicollet opened this issue Jun 24, 2017 · 3 comments
Closed

PHP 7.2: failed test #87

remicollet opened this issue Jun 24, 2017 · 3 comments

Comments

@remicollet
Copy link
Contributor

Yes, early report ;)

TEST 7/20 [tests/trace_002.phpt]
========DIFF========
021+     > include("/builddir/build/BUILD/php72-php-pecl-trace-1.0.1/trace-1.0.1beta/extension/tests/trace_002_include.inc") called at [/builddir/build/BUILD/php72-php-pec
022+ Deprecated: Function create_function() is deprecated in /builddir/build/BUILD/php72-php-pecl-trace-1.0.1/trace-1.0.1beta/extension/tests/trace_002.php on line 11
023+ l-trace-1.0.1/trace-1.0.1beta/extension/tests/trace_002.php:8]
021-     > include("%s_include.inc") called at [%s:8]
029+ 
030+ Deprecated: Function create_function() is deprecated in /builddir/build/BUILD/php72-php-pecl-trace-1.0.1/trace-1.0.1beta/extension/tests/trace_002.php on line 13
========DONE========
FAIL Trace include, require, lambda, eval [tests/trace_002.phpt] 

Tests failed    :    1 (  5.0%) ( 14.3%)
Tests passed    :    6 ( 30.0%) ( 85.7%)

@silkcutKs
Copy link
Collaborator

skip the test maybe not the best choice, we should lost some error check, if we add a '@' at the function to avoid the error???

@remicollet
Copy link
Contributor Author

@ could work... but SKIPIF will be required later, when removed ;)

@silkcutKs
Copy link
Collaborator

yes , when the function remove the test expect also shold change. but at that time , we will add another test file which can include currrent test file and add other features :)

@monque monque closed this as completed in 0ef8d69 Nov 28, 2018
monque added a commit that referenced this issue Nov 28, 2018
Fix #87 skip test with 7.2 (create_function is deprecated)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants