Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加创建部署资源单位,样式调整 #27

Merged
merged 3 commits into from
Nov 20, 2018

Conversation

BennieMeng
Copy link
Collaborator

创建部署资源单位, label 样式调整。

@wilhelmguo wilhelmguo self-requested a review November 20, 2018 08:38
@wilhelmguo wilhelmguo self-assigned this Nov 20, 2018
@wilhelmguo wilhelmguo added sig/frontend Categorizes an issue or PR as relevant to sig-frontend. kind/enhancement Categorizes issue or PR as related to enhancement. labels Nov 20, 2018
@wilhelmguo
Copy link
Collaborator

/lgtm @chengyumeng

[(ngModel)]="resourcesMetas.memoryLimit"
#memoryLimit="ngModel">
<span class="tooltip-content">
请填写内存限制份数.
</span>
</label>
<div class="percent-label">Gi</div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个直接写成G

@@ -103,14 +105,16 @@ <h3 class="modal-title">{{title}}</h3>
<input type="text" id="memoryLimit" placeholder="内存限制"
type="number"
name="memoryLimit"
style="width: 110px;"
[(ngModel)]="resourcesMetas.memoryLimit"
#memoryLimit="ngModel">
<span class="tooltip-content">
请填写内存限制份数.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“份数”这种可以改成不那么口语化 #TODO

@chengyumeng
Copy link
Collaborator

#7

@chengyumeng chengyumeng merged commit 14cbc39 into Qihoo360:master Nov 20, 2018
@wilhelmguo wilhelmguo changed the title frontend: 添加创建部署资源单位,样式调整 添加创建部署资源单位,样式调整 Dec 12, 2018
@BennieMeng BennieMeng deleted the feature/resource-unit-add branch August 28, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to enhancement. sig/frontend Categorizes an issue or PR as relevant to sig-frontend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants