Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load apikeys error when not set APIKey #33

Merged
merged 4 commits into from
Nov 21, 2018

Conversation

wilhelmguo
Copy link
Collaborator

No description provided.

@wilhelmguo wilhelmguo added kind/bug Categorizes issue or PR as related to a bug. sig/backend Categorizes an issue or PR as relevant to sig-backend. sig/frontend Categorizes an issue or PR as relevant to sig-frontend. labels Nov 20, 2018
@wilhelmguo
Copy link
Collaborator Author

@chengyumeng EnableApiKeys default set true

@wilhelmguo
Copy link
Collaborator Author

wilhelmguo commented Nov 21, 2018

#9

@chengyumeng chengyumeng merged commit 9684c62 into Qihoo360:master Nov 21, 2018
Copy link
Collaborator

@BennieMeng BennieMeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other well

@@ -20,7 +20,7 @@
title="APIKeys"
routerLink="/portal/namespace/{{cacheService.currentNamespace?.id}}/apikey"
routerLinkActive="active"
*ngIf="authService.currentNamespacePermission.apiKey.read || authService.currentUser.admin">
*ngIf="this.authService.config['enableApiKeys'] && (authService.currentNamespacePermission.apiKey.read || authService.currentUser.admin)">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么要加this

@wilhelmguo wilhelmguo changed the title if load enable apikeys by config Fix load apikeys error when not set APIKey Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/backend Categorizes an issue or PR as relevant to sig-backend. sig/frontend Categorizes an issue or PR as relevant to sig-frontend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants