Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ace switch error notify #34

Merged

Conversation

BennieMeng
Copy link
Collaborator

针对目前出现的用户在编辑ace模板时候内容为空或者出错无法切换语言的问题。
修改逻辑为:1. 为空时候可以切换; 2. 内容出错时候点击切换给出提示;3. 内容为空时候统一输出为空字符串。

@BennieMeng
Copy link
Collaborator Author

@wilhelmguo @chengyumeng pls review

@wilhelmguo wilhelmguo added sig/frontend Categorizes an issue or PR as relevant to sig-frontend. kind/enhancement Categorizes issue or PR as related to enhancement. labels Nov 21, 2018
@wilhelmguo
Copy link
Collaborator

/lgtm

@wilhelmguo wilhelmguo merged commit 0c8ea9c into Qihoo360:master Nov 21, 2018
@BennieMeng BennieMeng deleted the feature/ace-switch-error-notify branch August 28, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to enhancement. sig/frontend Categorizes an issue or PR as relevant to sig-frontend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants