Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sphinx build by depending on ipykernel directly #345

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

garrison
Copy link
Member

@garrison garrison commented Aug 1, 2023

This adds a dependency on ipykernel, the lack of which caused CI failures in #343 and #344. jupyter/jupyter-sphinx#226 is my attempt to "fix" this upstream.

@garrison garrison added the dependencies Pull requests that update a dependency file label Aug 1, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5730530011

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.89%

Totals Coverage Status
Change from base Build 5697731965: 0.0%
Covered Lines: 2614
Relevant Lines: 2876

💛 - Coveralls

Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch and fixes (even upstream ;) )

@garrison garrison merged commit e4d1d0d into main Aug 1, 2023
10 checks passed
@garrison garrison deleted the fix-sphinx-build branch August 1, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants