Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add option to fix value associated with the HF bitstring #64

Closed
wants to merge 7 commits into from

Conversation

caleb-johnson
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Dec 6, 2022

Pull Request Test Coverage Report for Build 3631618699

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 56 of 70 (80.0%) changed or added relevant lines in 2 files are covered.
  • 67 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.004%) to 84.765%

Changes Missing Coverage Covered Lines Changed/Added Lines %
circuit_knitting_toolbox/entanglement_forging/entanglement_forging_ground_state_solver.py 19 24 79.17%
circuit_knitting_toolbox/entanglement_forging/entanglement_forging_knitter.py 37 46 80.43%
Files with Coverage Reduction New Missed Lines %
circuit_knitting_toolbox/entanglement_forging/entanglement_forging_ansatz.py 11 73.33%
circuit_knitting_toolbox/entanglement_forging/entanglement_forging_ground_state_solver.py 24 83.92%
circuit_knitting_toolbox/entanglement_forging/entanglement_forging_knitter.py 32 82.13%
Totals Coverage Status
Change from base Build 3605593646: -0.004%
Covered Lines: 1530
Relevant Lines: 1805

💛 - Coveralls

Copy link
Member

@garrison garrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a correct and fine addition. I believe my only comment is that it's not clear to me what it means precisely to "fix" the first HF value (the code/comment implies it is dropped from the tensor prep circuits?), and why one might want to do this. I wonder if there's an improvement that could be made to another section of the documentation other than the docstrings (e.g., explanatory material).

@caleb-johnson
Copy link
Collaborator Author

This looks like a correct and fine addition. I believe my only comment is that it's not clear to me what it means precisely to "fix" the first HF value (the code/comment implies it is dropped from the tensor prep circuits?), and why one might want to do this. I wonder if there's an improvement that could be made to another section of the documentation other than the docstrings (e.g., explanatory material).

Yes, there is some good documentation on this feature in the prototype. I will move it over in this PR

@caleb-johnson caleb-johnson added the on hold Let's wait for something before merging label Apr 14, 2023
@caleb-johnson caleb-johnson added enhancement New feature or request and removed on hold Let's wait for something before merging labels May 5, 2023
@garrison garrison added this to the 0.2.0 milestone May 5, 2023
@caleb-johnson caleb-johnson modified the milestones: 0.2.0, 0.3.0 May 6, 2023
@caleb-johnson caleb-johnson self-assigned this May 6, 2023
@caleb-johnson caleb-johnson added the on hold Let's wait for something before merging label May 8, 2023
@caleb-johnson caleb-johnson deleted the fix-first-bitstring branch July 8, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request on hold Let's wait for something before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants