-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add option to fix value associated with the HF bitstring #64
Conversation
Pull Request Test Coverage Report for Build 3631618699Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a correct and fine addition. I believe my only comment is that it's not clear to me what it means precisely to "fix" the first HF value (the code/comment implies it is dropped from the tensor prep circuits?), and why one might want to do this. I wonder if there's an improvement that could be made to another section of the documentation other than the docstrings (e.g., explanatory material).
Yes, there is some good documentation on this feature in the prototype. I will move it over in this PR |
No description provided.