Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mappings 2.0 #133

Merged
merged 19 commits into from
Feb 9, 2023
Merged

Mappings 2.0 #133

merged 19 commits into from
Feb 9, 2023

Conversation

nonhermitian
Copy link
Collaborator

@nonhermitian nonhermitian commented Feb 8, 2023

This PR changes the way the final measurement mappings are computed so that they allow for repeated qubit measurement, e.g. as allowed by mid-circuit measurements / dynamic circuits. Previously the mapping dicts had qubits as the keys and bits as the values. However, mid-circuit measurement allows for the same qubit to be measured multiple times to different bits, and thus qubits cannot be used as key values in a dict.

This is a breaking change, which is why the version was bumped, #132, as we are keeping the same dict class for the mapping, and thus users inputting the mappings by hand would need to change their dict form.

Things left to do

  • Add dynamic BV test
  • Update docs

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nonhermitian nonhermitian changed the title [WIP] Mappings 2.0 Mappings 2.0 Feb 9, 2023
@nonhermitian nonhermitian merged commit 05343d3 into main Feb 9, 2023
@nonhermitian nonhermitian deleted the mapping-2.0 branch February 9, 2023 22:04
@nonhermitian nonhermitian added this to the Version 2.0 milestone Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant