Fix release ci config issues, drop 3.7 support, and prepare 2.6.2 release #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ease This commit fixes a release ci job configuration issue stemming from the fact that the release ci jobs are setup to parallelize the sdist and wheel publishing. The issue with this is the sdist, being just a tarball, is significantly faster to publish and always goes first. But the wheel builds which actually compile the cython code and run tests are slower and much more fragile. We've had two releases in quick succession where small oversights in the packaging configuration caused the wheel jobs to fail, but by the time we hit the failure the sdist had already been published to pypi which makes it hard to rollback. This commit updates the ci configuration to fix this and only upload the sdist after the wheels are there. Then to prepare for the second patch release on 2.6.x this commit drops support for python 3.7 and updates the ci jobs and package metadata to indicate 3.7 is no longer supported and no longer build or test it.
nonhermitian
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a release ci job configuration issue stemming from the fact that the release ci jobs are setup to parallelize the sdist and wheel publishing. The issue with this is the sdist, being just a tarball, is significantly faster to publish and always goes first. But the wheel builds which actually compile the cython code and run tests are slower and much more fragile. We've had two releases in quick succession where small oversights in the packaging configuration caused the wheel jobs to fail, but by the time we hit the failure the sdist had already been published to pypi which makes it hard to rollback. This commit updates the ci configuration to fix this and only upload the sdist after the wheels are there.
Then to prepare for the second patch release on 2.6.x this commit drops support for python 3.7 and updates the ci jobs and package metadata to indicate 3.7 is no longer supported and no longer build or test it.