Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Basic QST experiment class example #7

Closed
wants to merge 2 commits into from

Conversation

chriseclectic
Copy link
Collaborator

Summary

This PR isn't intended for merging, but rather as a basic implementation of an experiment subclass.

Here a simple Pauli basis measurement quantum state tomography experiment is implemented. It depends on ignis, and is just a wrapper for internal tomography functions in ignis.

See the example notebook for demonstration.

Details and comments

Copy link
Contributor

@yaelbh yaelbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that this is not for merging, but want to point out the fix nevertheless. Also, in the notebook, replace cell 10 by:

for i in range(3):
    print(par_data.component_experiment_data(i), '\n')

def _run_analysis(self, experiment_data, **params):
# Options
standard_weights = params.pop("standard_weights", True)
beta = params.pop("beta", 0.5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage of pop should be replaced by get

initial state circuit. If a Gate or Operator it will be
appended to a quantum circuit.
qubits (int or list or None): Optional, the qubits to be measured.
If None all qubits will be measured.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basis missing from docstring

@nkanazawa1989 nkanazawa1989 mentioned this pull request Apr 1, 2021
@chriseclectic
Copy link
Collaborator Author

Closing this since I started an PR for the actual tomography experiment

@chriseclectic chriseclectic deleted the qst-demo branch July 21, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants