Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Service Serialization #796

Merged
merged 12 commits into from
May 18, 2022
Merged

Fix for Service Serialization #796

Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
922baf0
Added warning for saving service class.
ItamarGoldman May 2, 2022
6c1736e
Update __init__.py
ItamarGoldman May 2, 2022
5d90b68
lint + black
ItamarGoldman May 2, 2022
2e5f660
Merge remote-tracking branch 'upstream/main' into Issue_714
ItamarGoldman May 9, 2022
bae21a1
Log message added for objects that aren't serialized
ItamarGoldman May 9, 2022
0a859fa
Merge remote-tracking branch 'upstream/main' into Issue_714
ItamarGoldman May 11, 2022
8365611
Added tests for experiment data serialization and bug fix
ItamarGoldman May 12, 2022
0cc43da
Added tests for serialization
ItamarGoldman May 12, 2022
985867e
Merge branch 'main' into Issue_714
chriseclectic May 16, 2022
d1d7c79
Merge remote-tracking branch 'upstream/main' into Issue_714
ItamarGoldman May 17, 2022
d1aef66
Merge branch 'Issue_714' of github.com:ItamarGoldman/qiskit-experimen…
ItamarGoldman May 17, 2022
43ffb6b
Serialization of numpy.number in json file
ItamarGoldman May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions qiskit_experiments/database_service/db_experiment_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1835,8 +1835,6 @@ def __json_encode__(self):
for att in [
"_metadata",
"_source",
"_service",
ItamarGoldman marked this conversation as resolved.
Show resolved Hide resolved
"_backend",
"_id",
"_parent_id",
"_type",
Expand All @@ -1861,6 +1859,15 @@ def __json_encode__(self):
# Handle non-serializable objects
json_value["_jobs"] = self._safe_serialize_jobs()

# the attribute self._service in charge of the connection and communication with the
# experiment db. It doesn't have meaning in the json format so there is no need to serialize
# it.
for att in ["_service", "_backend"]:
json_value[att] = None
value = getattr(self, att)
if value is not None:
LOG.info("%s cannot be JSON serialized", str(type(value)))

return json_value

@classmethod
Expand Down